Restore formatTime #2420
Closed
Restore formatTime #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
| @@ -397,6 +398,20 @@ videojs.log = log; | |||
| videojs.createTimeRange = createTimeRange; | |||
|
|
|||
| /** | |||
| * @file format-time.js | |||
There was a problem hiding this comment.
Ah, I see. copy/paste. The @file isn't needed here, and could probably be moved into it's own comment block in format-time.js to avoid future issues like this.
|
Need to remove the |
|
|
Several core plugins use this method and there is at least one external plugin that uses it (found via GitHub issues).
misteroneill
force-pushed
the
restore-format-time
branch
from
15b3028
to
bd50a3a
Compare
|
seconded! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several core plugins use this method and there is at least one external plugin that uses it (found via GitHub issues).