Apply aria-hidden to control-bar when userinactive #3023
Conversation
Defaults to aria-hidden:true because the controls are hidden by default.
|
And got it to not go inactive when focused inside the player. That was surprisingly easy. |
| @@ -2256,6 +2256,11 @@ class Player extends Component { | |||
| this.addClass('vjs-user-active'); | |||
| this.trigger('useractive'); | |||
| } else { | |||
| // if we are focused anywhere in the player, don't go inactive | |||
| if (player.el().contains(document.activeElement)) { | |||
There was a problem hiding this comment.
maybe this should be player.controlBar.el().contains(document.activeElement)?
And then <Esc> would focus the player div?
| @@ -2256,6 +2256,11 @@ class Player extends Component { | |||
| this.addClass('vjs-user-active'); | |||
| this.trigger('useractive'); | |||
| } else { | |||
| // if we are focused anywhere in the player, don't go inactive | |||
| if (this.el().contains(document.activeElement)) { | |||
There was a problem hiding this comment.
maybe this should be this.controlBar.el().contains(document.activeElement)?
And then <Esc> would focus the player div?
|
This should help with #2156 but it doesn't currently fix the trying to tab back into the player part of that issue. |
|
Talking this over with @OwenEdwards, we realized we want to do basically the opposite of what this PR does. When the controls go inactive, it should only be visual. The controls should still work for Screen Readers. I'll close this and approach this problem from that direction. |
|
@gkatsev "...still work for Screen Readers" and keyboard-only users. I'm going to keep hammering on that point, that these are two different groups of users (although they experience related accessibility issues). Honestly, you'll miss me when I don't need to mention it again ;-) |
|
Yeah, it didn't feel right to not go inactive on focus but didn't understand exactly where I was going wrong. :D |
Defaults to aria-hidden:true because the controls are hidden by default.
The next step here is to try and prevent the control bar from hiding when it has keyboard focus.