Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alternate CSS as video-js-cdn.css #3118

Closed
wants to merge 1 commit into from
Closed

Add alternate CSS as video-js-cdn.css #3118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions build/grunt.js
View file
Open in desktop
Expand Up @@ -192,15 +192,16 @@ module.exports = function(grunt) {
minify: {
expand: true,
cwd: 'build/temp/',
src: ['video-js.css'],
src: ['video-js.css', 'alt/video-js-cdn.css'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this minify task accidentally keep the minified version into build/temp/?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything ends up in the right place - build/temp/alt/ and dist/alt/.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, must be minify/grunt "magic" based on the src file.

dest: 'build/temp/',
ext: '.min.css'
}
},
sass: {
build: {
files: {
'build/temp/video-js.css': 'src/css/vjs.scss'
'build/temp/video-js.css': 'src/css/vjs.scss',
'build/temp/alt/video-js-cdn.css': 'src/css/vjs-cdn.scss'
}
}
},
Expand Down
3 changes: 3 additions & 0 deletions src/css/vjs-cdn.scss
View file
Open in desktop
@@ -0,0 +1,3 @@
$icon-font-path: '//vjs.zencdn.net/font/1.5.1';

@import 'video-js';