Unit test linting #3490
Merged
Unit test linting #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagarwal123
force-pushed
the
unit-test-linting
branch
from
a4c228a
to
054cfc2
Compare
| var parent, options; | ||
| QUnit.test('should allows setting child options at the parent options level', function() { | ||
| let parent; | ||
| let options; |
There was a problem hiding this comment.
Can we combine this declaration and the assignment on line 189? let options = {
misteroneill
force-pushed
the
vjsstandard-core
branch
from
deddb6b
to
caf614e
Compare
| @@ -686,31 +711,31 @@ test('should emit a tap event', function(){ | |||
| browser.TOUCH_ENABLED = origTouch; | |||
| }); | |||
|
|
|||
| test('should provide timeout methods that automatically get cleared on component disposal', function() { | |||
| expect(4); | |||
| QUnit.test('should provide timeout methods that automatically get cleared on component disposal', | |||
There was a problem hiding this comment.
you can put the function back on this line, we are going to work on ignoring the length of unit test name lines
There was a problem hiding this comment.
Yeah, good idea. We can roll back the line length changes if we want.
misteroneill
force-pushed
the
vjsstandard-core
branch
from
20867da
to
99724c6
Compare
|
|
||
| player.tech_['featuresVolumeControl'] = true; | ||
| player.tech_.featuresVolumeControl = true; | ||
| for (i = 0; i < listeners.length; i++) { |
There was a problem hiding this comment.
take the let i from the top of this function and instead put it in this for statement for (let i = 0;...
pagarwal123
force-pushed
the
unit-test-linting
branch
from
58f915a
to
b351a7d
Compare
|
LGTM other than the some minor comments and some |
| comp1.off = function(){ throw 'Comp1 off called'; }; | ||
| QUnit.equal(listenerFired, 0, 'listener was removed when this component was disposed first'); | ||
| comp1.off = function() { | ||
| throw new Error('Comp1 off called'); |
There was a problem hiding this comment.
Thanks for making this a new Error!
|
almost there! |
|
LGTM |
|
LGTM |
misteroneill
added
confirmed
and removed
needs: LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files updated for videojs-standard v5:
button.test.js
clickable-component.test.js
close-button.test.js
component.test.js
controls.test.js
events.test.js
extend.test.js
menu.test.js
modal-dialog.test.js
player.test.js
Requirements Checklist