Vttjs 5.x #4131
Merged
Vttjs 5.x #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
justinanastos
approved these changes
Feb 24, 2017
misteroneill
approved these changes
Feb 24, 2017
brandonocasey
approved these changes
Feb 27, 2017
justinanastos
added a commit
to justinanastos/videojs-contrib-dash
that referenced
this pull request
Feb 28, 2017
The v5.18.0 release of video.js includes a fix for videojs/video.js#4093 with videojs/video.js#4131. This is neccessary for text tracks to work in Chrome.
justinanastos
added a commit
to justinanastos/videojs-contrib-dash
that referenced
this pull request
Apr 4, 2017
The v5.18.0 release of video.js includes a fix for videojs/video.js#4093 with videojs/video.js#4131. This is neccessary for text tracks to work in Chrome.
justinanastos
added a commit
to justinanastos/videojs-contrib-dash
that referenced
this pull request
Apr 4, 2017
The v5.18.0 release of video.js includes a fix for videojs/video.js#4093 with videojs/video.js#4131. This is neccessary for text tracks to work in Chrome.
justinanastos
added a commit
to justinanastos/videojs-contrib-dash
that referenced
this pull request
Apr 4, 2017
The v5.18.0 release of video.js includes a fix for videojs/video.js#4093 with videojs/video.js#4131. This is neccessary for text tracks to work in Chrome.
justinanastos
added a commit
to justinanastos/videojs-contrib-dash
that referenced
this pull request
Apr 14, 2017
The v5.18.0 release of video.js includes a fix for videojs/video.js#4093 with videojs/video.js#4131. This is neccessary for text tracks to work in Chrome.
justinanastos
added a commit
to justinanastos/videojs-contrib-dash
that referenced
this pull request
Apr 14, 2017
The v5.18.0 release of video.js includes a fix for videojs/video.js#4093 with videojs/video.js#4131. This is neccessary for text tracks to work in Chrome.
justinanastos
added a commit
to justinanastos/videojs-contrib-dash
that referenced
this pull request
Apr 14, 2017
The v5.18.0 release of video.js includes a fix for videojs/video.js#4093 with videojs/video.js#4131. This is neccessary for text tracks to work in Chrome.
justinanastos
added a commit
to justinanastos/videojs-contrib-dash
that referenced
this pull request
Apr 14, 2017
The v5.18.0 release of video.js includes a fix for videojs/video.js#4093 with videojs/video.js#4131. This is neccessary for text tracks to work in Chrome.
justinanastos
added a commit
to justinanastos/videojs-contrib-dash
that referenced
this pull request
Apr 14, 2017
The v5.18.0 release of video.js includes a fix for videojs/video.js#4093 with videojs/video.js#4131. This is neccessary for text tracks to work in Chrome.
forbesjo
pushed a commit
to videojs/videojs-contrib-dash
that referenced
this pull request
May 11, 2017
* Use dash controlled text tracks As of video.js v5.14, video.js no longer supports native subtitles on anything besides Safari. For Chrome, this means there is *no* subtitle support with mpeg-dash. This will wait for dash.js to load all the text tracks and then add them to video.js if we're using a version that does not attempt to use native subtitles. When the video.js menu is used to change captions, we'll set the corresponding active text track in dash. We *cannot* dynamically add text track cues to video.js beacuse fragmented text tracks are loaded on the fly and there's no event fired when they are loaded. Therefore, we must has dash to natively display captions. * Update README.md to describe `nativeCaptions` usage requirements * Require videojs@v5.18 The v5.18.0 release of video.js includes a fix for videojs/video.js#4093 with videojs/video.js#4131. This is neccessary for text tracks to work in Chrome. * fixup! Use dash controlled text tracks - Only set `textTrack.mode` for `captions` and `subtitles. - Don't call the initial `updateActiveDashTextTrack` until after the `textTrack.mode`s have been set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #4115 but against 5.x.
cc @justinanastos.