Add getVideoPlaybackQuality API #4286
Conversation
src/js/player.js
Outdated
| * is no tech or the tech does not support it. | ||
| */ | ||
| getVideoPlaybackQuality() { | ||
| if (this.tech_ && this.tech_.getVideoPlaybackQuality) { |
There was a problem hiding this comment.
there's the techGet_ helper that you should use instead.
|
Updated to use |
|
Added abstract method |
|
@gkatsev PWEASE? |
src/js/player.js
Outdated
| * Gets available media playback quality metrics as specified by the W3C's Media | ||
| * Playback Quality API. | ||
| * | ||
| * @see https://wicg.github.io/media-playback-quality/ |
There was a problem hiding this comment.
elsewhere we use something like:
/*
* @see [Spec]{@link https://html.spec.whatwg.org/multipage/embedded-content.html#dom-media-play}
*/
And in the other comments.
| window.performance.timing && | ||
| typeof window.performance.timing.navigationStart === 'number') { | ||
| videoPlaybackQuality.creationTime = | ||
| window.Date.now() - window.performance.timing.navigationStart; |
There was a problem hiding this comment.
did we decide to have no value for creationTime if timing.navigationStart isn't available?
There was a problem hiding this comment.
By looking at the tests, I guess the answer is yes.
|
|
||
| const videoPlaybackQuality = {}; | ||
|
|
||
| if (typeof this.el().webkitDroppedFrameCount !== 'undefined' && |
There was a problem hiding this comment.
is it possible for only one to be available but not the other?
Also, do we want similar thing for the firefox mozilla prefixed items?
There was a problem hiding this comment.
Judging by https://bugs.webkit.org/attachment.cgi?id=80515&action=diff (which I think is the right patch), the webkit prefixed properties were added at the same time.
As for the mozilla prefixed properties, there do seem to be some:mozParsedFrames, mozDecodedFrames, mozPresentedFrames, mozPaintedFrames, and mozFrameDelay, but since they aren't 1:1 matches, I'm not sure it would be worth trying to use them.
|
Created Video.js 6 PRs: |
Description
NOTE: This requires videojs/video-js-swf#225
Provides a tech getter for getVideoPlaybackQuality as specified by the W3C's Media Playback Quality API: https://wicg.github.io/media-playback-quality/
Requirements Checklist