Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist caption/description choice over source changes #4295

Merged
merged 10 commits into from
May 25, 2017
Merged

Persist caption/description choice over source changes #4295

merged 10 commits into from
May 25, 2017

Commits on Apr 19, 2017

  1. Initial unit tests and work to persist a user choice

    @ldayananda
    ldayananda committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    35e4958 View commit details
    Browse the repository at this point in the history

  2. Handling Safari in the tests

    @ldayananda
    ldayananda committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    03a3b70 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2017

  1. Updates from code review comments

    @ldayananda
    ldayananda committed Apr 20, 2017
    Configuration menu
    Copy the full SHA
    ecf6b6f View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2017

  1. Changes to make sure track mode is changed when preselecting a language

    @ldayananda
    ldayananda committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    1001162 View commit details
    Browse the repository at this point in the history

  2. Make sure to keep the originally chosen track's kind on mode changes

    @ldayananda
    ldayananda committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    54506ea View commit details
    Browse the repository at this point in the history

  3. Updating tests and making sure only the most preferred text track is … 

    …selected
    @ldayananda
    ldayananda committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    27acd7e View commit details
    Browse the repository at this point in the history

  4. selectedlanguagechange on text track list rather than tech

    @ldayananda
    ldayananda committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    692783e View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2017

  1. Only preselect if there's a loadstart event in the text track display

    @ldayananda
    ldayananda committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    485fe93 View commit details
    Browse the repository at this point in the history

  2. Updated tests

    @ldayananda
    ldayananda committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    50f346e View commit details
    Browse the repository at this point in the history

Commits on May 16, 2017

  1. Always clear preselection if user turns off captions

    @ldayananda
    ldayananda committed May 16, 2017
    Configuration menu
    Copy the full SHA
    2eedf77 View commit details
    Browse the repository at this point in the history