New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor player.userActive() #4716

Merged
merged 4 commits into from Nov 16, 2017

Conversation

Projects
None yet
3 participants
@kocoten1992
Contributor

kocoten1992 commented Nov 3, 2017

Requirements Checklist

  • refactor player.userActive()

kocoten1992 added some commits Nov 3, 2017

@gkatsev

One suggestion, LGTM.

Show outdated Hide outdated src/js/player.js Outdated

@gkatsev gkatsev added the needs: LGTM label Nov 7, 2017

@gkatsev

gkatsev approved these changes Nov 7, 2017

/**
* @event Player#useractive
* @type {EventTarget~Event}
*/

This comment has been minimized.

@misteroneill

misteroneill Nov 13, 2017

Member

We need to preserve these JSDoc blocks.

@misteroneill

misteroneill Nov 13, 2017

Member

We need to preserve these JSDoc blocks.

/**
* @event Player#userinactive
* @type {EventTarget~Event}
*/

This comment has been minimized.

@misteroneill

misteroneill Nov 13, 2017

Member

We need to preserve these JSDoc blocks.

@misteroneill

misteroneill Nov 13, 2017

Member

We need to preserve these JSDoc blocks.

@gkatsev

LGTM

@misteroneill misteroneill added confirmed and removed needs: LGTM labels Nov 16, 2017

@gkatsev gkatsev merged commit 6cbe3ed into videojs:master Nov 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment