refactor player.userActive() #4716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Nov 7, 2017
src/js/player.js
Outdated
| return; | ||
| } | ||
|
|
||
| this.userActive_ = bool; |
There was a problem hiding this comment.
we should cast this to a boolean like previously to make sure that things don't break silently
!!bool
gkatsev
approved these changes
Nov 7, 2017
misteroneill
requested changes
Nov 13, 2017
| /** | ||
| * @event Player#useractive | ||
| * @type {EventTarget~Event} | ||
| */ |
There was a problem hiding this comment.
We need to preserve these JSDoc blocks.
| /** | ||
| * @event Player#userinactive | ||
| * @type {EventTarget~Event} | ||
| */ |
There was a problem hiding this comment.
We need to preserve these JSDoc blocks.
misteroneill
added
needs: updates
and removed
needs: LGTM
gkatsev
added
needs: LGTM
misteroneill
approved these changes
Nov 16, 2017
misteroneill
added
confirmed
and removed
needs: LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements Checklist