fix: adds correct cursor pointer for the play/pause controlbar button. #5463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
gkatsev
reviewed
Oct 1, 2018
src/css/components/_play-pause.scss
Outdated
| @@ -1,3 +1,6 @@ | |||
| .video-js .vjs-play-control { | |||
| cursor: pointer; | |||
| } | |||
| .video-js .vjs-play-control .vjs-icon-placeholder { | |||
| cursor: pointer; | |||
There was a problem hiding this comment.
this line is probably no longer necessary.
There was a problem hiding this comment.
Ah, you are right. Fixed now.
gkatsev
approved these changes
Oct 2, 2018
misteroneill
approved these changes
Oct 2, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A proposed fix for #5462
Requirements Checklist