Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: adds correct cursor pointer for the play/pause controlbar button. #5463
Conversation
gjanblaszczyk
added some commits
Sep 3, 2018
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Sep 29, 2018
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
gkatsev
reviewed
Oct 1, 2018
src/css/components/_play-pause.scss
Outdated
@@ -1,3 +1,6 @@ | |||
.video-js .vjs-play-control { | |||
cursor: pointer; | |||
} | |||
.video-js .vjs-play-control .vjs-icon-placeholder { | |||
cursor: pointer; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gkatsev
approved these changes
Oct 2, 2018
misteroneill
approved these changes
Oct 2, 2018
This comment has been minimized.
This comment has been minimized.
Thanks! |
gkatsev
referenced this pull request
Oct 2, 2018
Closed
Play/pause button doesn't show cursor pointer #5462
BrandonOCasey
added
the
confirmed
label
Oct 25, 2018
gkatsev
merged commit aed337a
into
videojs:master
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
gjanblaszczyk commentedSep 29, 2018
•
edited by gkatsev
Description
A proposed fix for #5462
Requirements Checklist