New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds correct cursor pointer for the play/pause controlbar button. #5463

Merged
merged 5 commits into from Nov 2, 2018

Conversation

Projects
None yet
4 participants
@gjanblaszczyk
Copy link
Contributor

gjanblaszczyk commented Sep 29, 2018

Description

A proposed fix for #5462

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

gjanblaszczyk added some commits Sep 3, 2018

Merge pull request #1 from videojs/master
sync with origin branch
@welcome

This comment has been minimized.

Copy link

welcome bot commented Sep 29, 2018

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@@ -1,3 +1,6 @@
.video-js .vjs-play-control {
cursor: pointer;
}
.video-js .vjs-play-control .vjs-icon-placeholder {
cursor: pointer;

This comment has been minimized.

@gkatsev

gkatsev Oct 1, 2018

Member

this line is probably no longer necessary.

This comment has been minimized.

@gjanblaszczyk

gjanblaszczyk Oct 2, 2018

Author Contributor

Ah, you are right. Fixed now.

@gkatsev

gkatsev approved these changes Oct 2, 2018

@misteroneill

This comment has been minimized.

Copy link
Member

misteroneill commented Oct 2, 2018

Thanks!

@gkatsev gkatsev merged commit aed337a into videojs:master Nov 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment