feat: add several debugging aides #5854
Conversation
| @@ -553,6 +554,8 @@ videojs.computedStyle = computedStyle; | |||
| */ | |||
| videojs.dom = Dom; | |||
|
|
|||
| videojs.domData = DomData; | |||
There was a problem hiding this comment.
I am against this being in a production build of Video.js, though, I do see the usefulness of it when debugging.
There was a problem hiding this comment.
If we can have this be here during local dev but not when releasing, that's fine.
There was a problem hiding this comment.
For local development we can just import DomData (as long as we let it export elData). I think that plugins could also benefit from being able to see what elData they may be leaking, but I am not quite sure how to do that without exposing it here.
There was a problem hiding this comment.
Perhaps we can expose it somewhere else? or put elData on the player somehow so that the player can remove it all on dispose?
There was a problem hiding this comment.
I'm not sure we can safely expose it and not deal with consequences down the line or have issues with people fiddling with it and causing issues.
| @@ -280,6 +280,7 @@ const EventedMixin = { | |||
| // Use the same function ID as the listener so we can remove it later | |||
| // it using the ID of the original listener. | |||
| wrapper.guid = listener.guid; | |||
| wrapper.original_ = listener.original_ || listener; | |||
There was a problem hiding this comment.
we'd want to make sure to null these out so that we're not leaking references.
| @@ -44,6 +44,9 @@ export const bind = function(context, fn, uid) { | |||
| // currently used in text tracks | |||
| bound.guid = (uid) ? uid + '_' + fn.guid : fn.guid; | |||
|
|
|||
| bound.original_ = fn.original_ || fn; | |||
There was a problem hiding this comment.
we should make sure to null these out when they're no longer needed.
brandonocasey
changed the title
|
After thinking about this more, maybe we just want to have another build target. Something like |
|
A debug build is fine, or having a rollup directive via envify or something that removes the exposing of domData when in production |
|
The issue in question #5858 |
TODO: Add some tests in this pull request to verify: