Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: turn off all track list listeners on dispose #5867

Merged
merged 3 commits into from Mar 18, 2019
Merged

fix: turn off all track list listeners on dispose #5867

merged 3 commits into from Mar 18, 2019

Conversation

brandonocasey
Copy link
Contributor

Description

Call off on TrackLists when the player is disposed so that we don't leak memory via DomData.elData

@brandonocasey brandonocasey mentioned this pull request Mar 15, 2019
Merged
@gkatsev gkatsev merged commit c632b24 into master Mar 18, 2019
@gkatsev gkatsev deleted the fix/track-list-off branch March 18, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandonocasey @gkatsev