Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix set method to use map property #7000

Merged
merged 1 commit into from Dec 17, 2020
Merged

fix: fix set method to use map property #7000

merged 1 commit into from Dec 17, 2020

Conversation

aildermi
Copy link
Contributor

Description

Bug was produced on an Android device using Chrome 34, which window.Map is not available. Error message Cannot set property 'TimeDisplay#updateTextNode_' of undefined was logged to console.
the set method in MapSham was using set_ property, which is not defined within MapSham class. map_ must be used instead.

Specific Changes proposed

Just changed src/js/utils/map.js file updating set method to use map_ instead of set_

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Dec 17, 2020

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's such a silly mistake.

@gkatsev gkatsev merged commit a35a121 into videojs:main Dec 17, 2020
@welcome
Copy link

welcome bot commented Dec 17, 2020

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants