fix: fix set method to use map property #7000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug was produced on an Android device using Chrome 34, which
window.Map
is not available. Error messageCannot set property 'TimeDisplay#updateTextNode_' of undefined
was logged to console.the
set
method inMapSham
was usingset_
property, which is not defined within MapSham class.map_
must be used instead.Specific Changes proposed
Just changed
src/js/utils/map.js
file updating set method to usemap_
instead ofset_
Requirements Checklist