Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove IE8 url parsing workaround #7334

Merged
merged 4 commits into from
Jul 22, 2021
Merged

fix: remove IE8 url parsing workaround #7334

merged 4 commits into from
Jul 22, 2021

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Jul 22, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #7334 (9def53c) into main (bba6e17) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7334      +/-   ##
==========================================
+ Coverage   79.53%   79.57%   +0.04%     
==========================================
  Files         115      115              
  Lines        7270     7262       -8     
  Branches     1747     1745       -2     
==========================================
- Hits         5782     5779       -3     
+ Misses       1488     1483       -5     
Impacted Files Coverage Δ
src/js/utils/url.js 78.04% <100.00%> (+8.66%) ⬆️
src/js/tracks/text-track.js 91.09% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba6e17...9def53c. Read the comment docs.

@gkatsev
Copy link
Member Author

gkatsev commented Jul 22, 2021

Fun, IE11 fails without this in some cases. Making changing how the removed code works causes it to fail to work as well. So, needs more thought here.

if (addToBody) {
document.body.removeChild(div);
if (!details.host) {
details.host = window.location.host;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov thinks this isn't covered, but it gets covered in IE11. We just only run coverage in chrome.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a special comment you can use to skip this if statement.

I think it's /* istanbul ignore if */ from https://github.com/gotwarlost/istanbul/blob/master/ignoring-code-for-coverage.md

@gkatsev gkatsev merged commit b3acf66 into main Jul 22, 2021
@gkatsev gkatsev deleted the parse-url branch July 22, 2021 17:14
jcilliers pushed a commit to totara/video.js that referenced this pull request Dec 16, 2021
jcilliers pushed a commit to totara/video.js that referenced this pull request Dec 17, 2021
jcilliers pushed a commit to totara/video.js that referenced this pull request Dec 19, 2021
jcilliers pushed a commit to totara/video.js that referenced this pull request Dec 19, 2021
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants