Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Lock old closed issues #7777

Merged
merged 1 commit into from
May 25, 2022

Conversation

mister-ben
Copy link
Contributor

Locks issues that have been closed for 60 days.

Why

People occasionally comment on old, closed issues that they are also having the "same issue". This is rarely useful:

  • the comment is less likely to be seen or responded to
  • it's probably not the same issue, even if a symptom is similar (like a generic error message)
  • the assertion that it's "still happening" is usually not presented with any actionable information, such as steps to reproduce

If someone believes they are having the "same" issue, they should create a new issue with their steps to reproduce and include a link to the closed issue.

Implementation

  • Uses Lock Threads action.
  • Locks closed issues after 60 days.
  • Does not lock PRs.
  • Runs once an hour, as the action processes max 50 items at a time. It can be reduced to daily once the backlog is clear.
  • Does not comment on the issue, the notifications would be annoying for old issues.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #7777 (7badbdd) into main (50ffd57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7777   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files         116      116           
  Lines        7461     7461           
  Branches     1811     1811           
=======================================
  Hits         6038     6038           
  Misses       1423     1423           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ffd57...7badbdd. Read the comment docs.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask if this will fight with stalebot but I guess this only looks at closed issues.

@misteroneill misteroneill merged commit 18bad57 into videojs:main May 25, 2022
misteroneill pushed a commit that referenced this pull request Nov 22, 2022
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants