fix: Use timeupdate as well as rvfc/raf for cuechanges #7918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7918 +/- ##
==========================================
+ Coverage 80.93% 80.94% +0.01%
==========================================
Files 116 116
Lines 7463 7467 +4
Branches 1813 1816 +3
==========================================
+ Hits 6040 6044 +4
Misses 1423 1423
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gkatsev
approved these changes
Sep 8, 2022
4 tasks
misteroneill
pushed a commit
that referenced
this pull request
Nov 22, 2022
Use the timeupdate event as well as the rvfc and raf callbacks to check cues. This is a bit overkill for "usual" playback but avoids edge cases. If the more preceise callback trigger first the cue will update but the timeupdate event should catch any that were missed, notwithstanding that timeupdate was always somewhat unpredictable. Fixes #7910 (audio in video els and Samsung being weird) and fixes #7902 (no updates off screen).
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Use the timeupdate event as well as the rvfc and raf callbacks to check cues. This is a bit overkill for "usual" playback but avoids edge cases. If the more preceise callback trigger first the cue will update but the timeupdate event should catch any that were missed, notwithstanding that timeupdate was always somewhat unpredictable. Fixes videojs#7910 (audio in video els and Samsung being weird) and fixes videojs#7902 (no updates off screen).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple more edge cases have come up where usng rvfc or raf for more accurate cue changes isn't working., with audio in video els (there's already handling for audio in audio) and background tabs.
Specific Changes proposed
Use the
timeupdateevent as well as the rvfc and raf callbacks to check cues. This is a bit overkill for "usual" playback but avoids edge cases. If the more preceise callback trigger first the cue will update but the timeupdate event should catch any that were missed, notwithstanding thattimeupdatewas always somewhat unpredictable.Should fix #7910 (audio in video els and Samsung being weird) and #7902 (no updates off screen).
Requirements Checklist
Will need to be added to
next.