Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deprecation): deprecate the extend function #7944

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Conversation

misteroneill
Copy link
Member

@misteroneill misteroneill commented Sep 30, 2022

Description

Related to #7943, see that for details.

Specific Changes proposed

  • Deprecates the extend function

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #7944 (79ca933) into main (5bcf4d1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #7944      +/-   ##
==========================================
+ Coverage   80.94%   80.95%   +0.01%     
==========================================
  Files         116      116              
  Lines        7467     7471       +4     
  Branches     1816     1817       +1     
==========================================
+ Hits         6044     6048       +4     
  Misses       1423     1423              
Impacted Files Coverage Δ
src/js/extend.js 85.71% <100.00%> (+3.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@misteroneill misteroneill merged commit b58a220 into main Oct 3, 2022
@misteroneill misteroneill deleted the dep-extend branch October 3, 2022 21:22
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
This function will be removed in Video.js 8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants