Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Seek bar smooth seeking #8287

Merged
merged 3 commits into from
Jan 2, 2024
Merged

feat: Seek bar smooth seeking #8287

merged 3 commits into from
Jan 2, 2024

Commits on Nov 29, 2023

  1. refactor(player): decrease the indentation level in the currentTime m… 

    …ethod
    @amtins
    amtins committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    720eecf View commit details
    Browse the repository at this point in the history

  2. fix(player): cache_.currentTime is not updated when the current time … 

    …is set

Updating cache_.currentTime as soon as the currentTime is set avoids having to wait for the timeupdate event, which results in:

- making cache_.currentTime more reliable
- updating the progress bar on mouse up after dragging when the media is paused.

See also: videojs#6232, videojs#6234, videojs#6370, videojs#6372
    @amtins
    amtins committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9c6225b View commit details
    Browse the repository at this point in the history

  3. feat: add an option to handle smooth seeking 

    Adds a player option called enableSmoothSeeking, which is false by default,
to provide a smoother seeking experience on mobile and desktop devices.

Usage:
```javascript
// Enables the smooth seeking
const player = videojs('player', {enableSmoothSeeking: true});

// Disable the smooth seeking
player.options({enableSmoothSeeking: false});
```

- **player.js** add an `option` called `enableSmoothSeeking`
- **time-display.js** add a listener to the `seeking` event if `enableSmoothSeeking` is `true` allowing to update the `CurrentTimeDisplay` and `RemainingTimeDisplay` in real time
- **seek-bar.js** `update` the seek bar on `mousemove` event  if `enableSmoothSeeking` is `true`
- add test cases
    @amtins
    amtins committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    5b8b883 View commit details
    Browse the repository at this point in the history