fix(types): Fix issues in exported types #8333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8333 +/- ##
==========================================
+ Coverage 82.68% 82.69% +0.01%
==========================================
Files 113 113
Lines 7561 7578 +17
Branches 1818 1820 +2
==========================================
+ Hits 6252 6267 +15
- Misses 1309 1311 +2
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mister-ben
changed the title
Essk
approved these changes
Jul 4, 2023
misteroneill
requested changes
Jul 7, 2023
mister-ben
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
I think this is OK now, the unnecessary junk from package.json isn't being added. With this and #8218 we should be in a slightly better place wrt types.
|
Is it possible to merge this soon? |
|
Please merge this soon! |
|
I'd also appreciate if this would be merged soon 🙏 Currently, we have to do a bunch of @ts-ignore for types we know are correct. Thank you 🙏 |
dzianis-dashkevich
approved these changes
Sep 28, 2023
Essk
approved these changes
Sep 28, 2023
misteroneill
approved these changes
Sep 28, 2023
|
@boris-petrov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8301
Specific Changes proposed
Fix exported types.
Requirements Checklist