Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(title-bar): component remains displayed after player reset #8481

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

amtins
Copy link
Contributor

@amtins amtins commented Nov 4, 2023

Description

When player.reset is called the titleBar component is not reset.

Screencast.from.04.11.23.17.03.48.webm

Specific Changes proposed

  • Sets the properties title and description to undefined when player.titleBar.update is called so that the component is properly reset.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7972c23) 82.71% compared to head (6d128fb) 82.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8481   +/-   ##
=======================================
  Coverage   82.71%   82.72%           
=======================================
  Files         113      113           
  Lines        7592     7594    +2     
  Branches     1826     1827    +1     
=======================================
+ Hits         6280     6282    +2     
  Misses       1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When `player.reset` is called the `titleBar` component is not reset.

- Sets the properties `title` and `description` to `undefined` when `player.titleBar.update` is called so that the component is properly reset.
@mister-ben mister-ben merged commit 161a09c into videojs:main Nov 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants