Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: progress bar sometimes is not filled on 100% #8633

Merged
merged 2 commits into from
May 3, 2024

Conversation

gjanblaszczyk
Copy link
Member

Description

At the end of the video progress bar not in the end.
This is random behavior and it is best visible on short videos.

Screenshot from 2024-03-08 11-14-10

Screenshot from 2024-03-08 11-15-21

Specific Changes proposed

The player shouldn't throttle 'ended' event.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (9977a93) to head (4255ff8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8633      +/-   ##
==========================================
- Coverage   83.43%   82.71%   -0.72%     
==========================================
  Files         113      113              
  Lines        7636     7638       +2     
  Branches     1835     1835              
==========================================
- Hits         6371     6318      -53     
- Misses       1265     1320      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@chechebecomestrong
Copy link

Oh my, I encountered this issue today as well. My app is behaving very strangely, with short videos randomly getting stuck on a specific frame. But I found that it has not been merged in yet, when can the new version be released?

@mister-ben mister-ben merged commit 3e697e9 into videojs:main May 3, 2024
10 of 11 checks passed
@mister-ben
Copy link
Contributor

The test added here is susceptible to timing out on Safari if Safari is in the background, but passes consistently when in the foreground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants