Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use guid to ensure uniqueness of track setting options #8762

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

mister-ben
Copy link
Contributor

@mister-ben mister-ben commented Jun 9, 2024

The fix for the previous issue with the new text track settings introduced that ids would be re-used across players as there was no prefix for the settings that don't have a <label> for their <select>.

This change uses a generated guid for items without that label.
Fixes #8761

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Comment on lines -32 to -36
* @param {array} [options.SelectOptions]
* @param {Array} [options.SelectOptions]
* Array that contains the value & textContent of for each of the
* options elements.
*/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to issue, resolving jsdoc warnings from lint.

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (fc1f7a6) to head (cb4c2ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8762      +/-   ##
==========================================
+ Coverage   83.01%   83.62%   +0.61%     
==========================================
  Files         119      119              
  Lines        7993     7993              
  Branches     1922     1923       +1     
==========================================
+ Hits         6635     6684      +49     
+ Misses       1358     1309      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More duplicate HTML IDs
2 participants