fix: convert initData to a string #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to help get around the change in data type of initData between the legacy API and the standards API. In the legacy API, the initData was a Uint8Array but needed to be converted to a Uint16Array to be able to toString it. In the standards API, initData is an ArrayBuffer but can be converted to a Uint8Array to be able to toString it. We now do this string conversion for you so that you can just use the contentId and not need to figure out whether legacy or standard API is used. BREAKING CHANGE: getContentId will now receive a string representation of the initData
src/fairplay.js
Outdated
| @@ -128,8 +128,8 @@ export const defaultGetCertificate = (fairplayOptions) => { | |||
| }; | |||
| }; | |||
|
|
|||
| export const defaultGetContentId = (emeOptions, initData) => { | |||
| return getHostnameFromUri(uint8ArrayToString(initData)); | |||
| export const defaultGetContentId = (emeOptions, contentId) => { | |||
There was a problem hiding this comment.
perhaps this should be named initDataString now?
brandonocasey
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help get around the change in data type of initData between
the legacy API and the standards API.
In the legacy API, the initData was a Uint8Array but needed to be
converted to a Uint16Array to be able to toString it.
In the standards API, initData is an ArrayBuffer but can be converted to
a Uint8Array to be able to toString it.
We now do this string conversion for you so that you can just use the
contentId and not need to figure out whether legacy or standard API is
used.
BREAKING CHANGE: getContentId will now receive a string representation
of the initData