-
Notifications
You must be signed in to change notification settings - Fork 791
video.js 4.7.0 is incompatible with videojs-contrib-hls #128
Comments
Well, that was quick, since 4.7.0 was just released, but thanks. Though, it's weird because I don't think the swf was updated during 4.7.0 |
Isn't video-js.swf 4.4.2 new in video.js 4.7.0? On Tue, Aug 5, 2014, at 21:11, Gary Katsevman wrote:
|
I believe video-js-swf 4.4.2 is from videojs 4.6.4: https://github.com/videojs/video.js/pull/1343/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R24 and https://github.com/videojs/video.js/blob/master/CHANGELOG.md#464-2014-07-11 |
Ah, you're right. I think I must have forgot to upgrade the Flash On Wed, Aug 6, 2014, at 07:24, Gary Katsevman wrote:
|
Cool, thanks. Either way, needs to be fixed. Also, can you please describe in some more detail what you are seeing specifically? How is it broken? |
Attempting to seek causes video playback to stop and never resume. I see segments are still being downloaded, though. |
Segments seem to be delivered to the source buffer correctly. This is looking like a SWF issue. |
I've re-built the SWF at 4.4.2 locally and the seek problem disappears. The binaries differ. I'm going to look into what's going on with the published SWF but for now, it should be possible to workaround the problem by building it locally and pointing to your copy. It would be great if anyone else has a chance to confirm re-building fixes the issue. |
Bump the required version of video.js up to 4.7.2 because the earlier version built the SWF for a version of Flash that had issues with appendBytes. Handle autoplay inside the tech itself because video.js support calls play before the Media Source has opened and the call ended up ignored. Fixes #112. Fixes #128.
I was upgrading a site to video.js 4.7.0 and noticed that seeking in HLS is broken with the newer version of video.js. It seems that this is caused by some change in the Flash component because reverting to the
video-js.swf
from 4.6.4 makes it work again.The text was updated successfully, but these errors were encountered: