This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
[ABR] Handle "no playlist enabled" state in simple selector gracefully #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avior and an exception. When enforcing a single playlist (setting all to disabled and enabling one) currently we might have a moment where no playlist is enabled. But also the user may cause this state for various reasons on the API. We should be able to handle this gracefully (while eventually logging a warning)
|
Note: this is already contained in #1199 but I'll remove it from there, as it will be more consumable to ship things bit by bit per scope :) |
|
Thanks for the PR, this is definitely something we should handle gracefully. Implementation looks solid, would you be able to add a unit test for this behavior? (I agree, bit by bit is easier to consume 🙂) |
|
sure, will do 👍 |
6 tasks
|
We'll update this PR with tests. |
|
Thank you for your PR but we will not be accepting new changes for this repo and will be archived very soon. I would advise you to open your PR against the next iteration of this project at https://github.com/videojs/http-streaming. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we have no playlist enabled, currently this causes undefined behavior and an exception.
When enforcing a single playlist (setting all to disabled and enabling one) currently
we might have a moment where no playlist is enabled.
But also the user may cause this state for various reasons on the API.
We should be able to handle this gracefully (while eventually logging a warning)
Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist