This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Check plugin reloadSourceOnError is registered or not. #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forbesjo
reviewed
Aug 31, 2018
src/videojs-contrib-hls.js
Outdated
| @@ -601,7 +601,9 @@ videojs.m3u8 = m3u8; | |||
| videojs.options.hls = videojs.options.hls || {}; | |||
|
|
|||
| if (videojs.registerPlugin) { | |||
| videojs.registerPlugin('reloadSourceOnError', reloadSourceOnError); | |||
| if (!videojs.getPlugin('reloadSourceOnError') { | |||
There was a problem hiding this comment.
I would suggest deregistering the plugin if it exists so players would get the "newer" version of the plugin
fatelei
force-pushed
the
fix-reregister-reloadSourceOnError
branch
from
f142b9d
to
8aaabce
Compare
|
@forbesjo I fix the review issue |
|
Thank you for your PR but we will not be accepting new changes for this repo and will be archived very soon. I would advise you to open your PR against the next iteration of this project at https://github.com/videojs/http-streaming. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reloadSourceOnErrorplugin has already registered.Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist