Add MP3 audio support #214
Conversation
|
Thanks! We'll get it reviewed when we get the change. |
|
I will give testing some thought. Right now I have tested it manually with an actual transport stream. I would have to come up to speed on your unit testing framework. |
|
I added a unit test. |
| var mp3Tag = new FlvTag(FlvTag.AUDIO_TAG, undefined, FlvTag.MP3_AUDIO), | ||
| aacTag = new FlvTag(FlvTag.AUDIO_TAG, undefined, FlvTag.AAC_AUDIO); | ||
|
|
||
| equal(12, mp3Tag.length, 'mp3 tag length is 12'); |
There was a problem hiding this comment.
The expected value should be the second item with the actual value being the first.
|
@gkatsev Is there any news or updates regarding this pull request? |
|
We've done a lot of refactoring, could you open a PR against mux.js? Sorry about taking so long to get back to you. |
|
Did this ever get merged? I'm having some trouble getting mp3 audio to play. |
|
We are seeing this same problem with live streams published from FMLE: H264 video with MP3 audio (44htz) to Wowza 4.6.x. When the live video streams from FMLE include MP3 audio there is no sound. When published with AAC from FFMPEG or Wirecast the sound renders. We understand that this is a legacy application but want to head off any future support issues if FMLE or an MP3 codec is used in the future. The playlist shows MP3 codec as as mp4a.40.34. Which should be right? I think this ticket deals with MP3 Audio Only streaming but it sounds like a variation of the same problem. I also think the same problem exists in HLS.js when we test with the demo player. We are still learning the framework and protocol for bugs so forgive me if I missed something or posted in the wrong place. |
|
I also wanted to add that the use case here is less FMLE but more important for users of vMix or older Tricasters which still automate FMLE behind the scene. |
|
Has there been any progress on this issue? I have a project that is pulling an m4u8 playlist with mp3s from a WowzaStreamingEngine/4.7.0 server, it reads the playlist, but when it tries to play an individual mp3 it just hangs. Any update would be helpful. Thanks. |
ghost
mentioned this pull request
Based on the previous work of @raytiley.