This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Added GOAL_BUFFER_LENGTH_BEFORE_PLAYING option #927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Jan 26, 2018
There was a problem hiding this comment.
Sorry the PR has gone on for a while without much response.
@servercimen , are you still looking for this feature?
If so, would it be possible to update it to use the goalBufferLength function in MasterPlaylistController and add some tests and a README update?
Thanks for the contribution!
| @@ -433,7 +433,8 @@ export default class SegmentLoader extends videojs.EventTarget { | |||
|
|
|||
| // if the video has not yet played once, and we already have | |||
| // one segment downloaded do nothing | |||
| if (!hasPlayed && bufferedTime >= 1) { | |||
|
|
|||
| if (!hasPlayed && bufferedTime >= Config.GOAL_BUFFER_LENGTH_BEFORE_PLAYING) { | |||
There was a problem hiding this comment.
We now have a function, goalBufferLength in MasterPlaylistController that may be a good spot for this to exist.
|
Thank you for your PR but we wont be adding this setting at this time since there doesn't seem to be much demand. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, it is not possible to configure goal buffer length for when the player hasn't started played.
1is hard coded. This pull request moves that value to a config option.Specific Changes proposed
Move hard coded value to config option.
Requirements Checklist