support ie8 #10
Merged
support ie8 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Feb 7, 2017
src/quality-level.js
Outdated
| level.bitrate = representation.bandwidth; | ||
| level.enabled_ = representation.enabled; | ||
|
|
||
| return level; |
There was a problem hiding this comment.
just doing this makes the get syntax below work fine?
There was a problem hiding this comment.
Turns out no. I had my IE emulation settings wrong when testing the behavior
There was a problem hiding this comment.
IE emulation settings? Make sure to test in IE8 directly. compatibility modes in newer IEs aren't sufficient.
|
Looks good to me |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #9