Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow video js 6 to be used #25

Merged
merged 2 commits into from
Jan 22, 2018
Merged

Conversation

199911
Copy link
Contributor

@199911 199911 commented Dec 28, 2017

Allow this plugin to be used in video.js 6

Copy link
Contributor

@gesinger gesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. Thanks for the PR!

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "videojs-contrib-quality-levels",
"version": "2.0.3",
"version": "2.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually this is done outside of PRs, to allow us to package multiple changes together (and prevent conflicts before PRs get merged). Would it be possible to set this back to 2.0.3?

@gesinger gesinger merged commit 19f4b2f into videojs:master Jan 22, 2018
volkirik added a commit to volkirik/videojs-contrib-quality-levels that referenced this pull request Jun 3, 2018
* Allow video js 6 to be used (videojs#25)

* Update changelog

* 2.0.4

* Update dependencies to enable Greenkeeper 🌴 (videojs#26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants