Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chrome m55 android gyro breakage by updating webvr-polyfill #64

Merged
merged 2 commits into from
Mar 27, 2018
Merged

fix: chrome m55 android gyro breakage by updating webvr-polyfill #64

merged 2 commits into from
Mar 27, 2018

Conversation

brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented Mar 22, 2018 •
edited
Loading

This is currently broken in every version of videojs-vr and webvr-polyfill < 0.10.2
See: immersive-web/webvr-polyfill#307

I also:

  • exported vr on window for the test page
  • added an iframe
  • exported the polyfill version in a function
  • and fixed karma-qunit, which is currently broken in master

@brandonocasey brandonocasey changed the title fix: chrome m55 gyro breakage by updating webvr-polyfill fix: chrome m55 android gyro breakage by updating webvr-polyfill Mar 22, 2018
@brandonocasey brandonocasey force-pushed the fix/devicemotion-chrome-m55 branch 2 times, most recently from 5fb193b to 01ba7d4 Compare March 22, 2018 20:46
@brandonocasey brandonocasey merged commit ff8e461 into master Mar 27, 2018
@brandonocasey brandonocasey deleted the fix/devicemotion-chrome-m55 branch May 9, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @misteroneill