Does not handle calls to .src(src)

[tomsaffell]

Hi Exon,

Great work getting this going. I tried the example, and it worked great. Then I tried to play videos via the .src() call to videojs. e.g.

video.src({type: 'video/youtube', src: 'http://www.youtube.com/watch?v=xjS6SftYQaQ'}

Which doesnt work, because there is no .src() function to handle that. I have created a fix for this which works, but doesnt yet handle the case where the video src is specified in the html. So I need to re-apply some of the original code before it's merge ready. I also moved a few things around to factor-out the regexing the of the IDs from the init. If you have time to jump on IRC at some point we could figure how best to merge it back.

tom

[jontroncoso]

Hey there, tomsaffell. I am in need of this fix for a project I am working on, would you be able to share the code with me? You can find my email on my profile.

[tomsaffell]

hi @OmniTool. You can find my fork here: https://github.com/tomsaffell/videojs-youtube
warning: it's pretty rough around the edges - I changed it to do specifically what we need, but I didnt ensure that I didnt break other use cases in the process. We use it in production.

To use:

player.src({type: 'video/youtube', src: 'https://www.youtube.com/watch?v=xxxxxxx'})

[eXon]

@tomsaffell I would like to fork back your work, this feature is missing and should be available. What's stopping you from making it ready to test right now?

[tomsaffell]

@eXon I'm pretty sure I broke the original method for specifying the src. I wouldnt be hard to merge the two together, I just dont have the time right now, which is why I didnt submit a PR. You're very welcome to merge the two together. Do you need any info from me to do that?

[eXon]

I will probably just take your code and rewrite it inside my branch. I'm having trouble because the loadVideoById doesn't seem to work inside the videojs.Youtube.prototype.src. What HTML code are you using to test this?

Also, any reason why you are forcing the YouTube controls on Android and iOS?

[tomsaffell]

Yeah, manually merging them is probably the best option. You can see a working example here:
http://tcsdev.www.videopixie.com/st/dev/vjs4.3.html which will show how we're setting up VJS and calling it.

Also, any reason why you are forcing the YouTube controls on Android and iOS?

Because my test indicated that on iOS (and some versions of Android) the browser would render YT's controls no matter what I did (causing double controls), so I defaulted it to not show the VJS controls in that case. Related to this: VJS has some issues around when to show controls, especially when switching techs. The state variables that determine whether the controls should be shown are messed up when switching techs. Try switching techs in the example above and you'll see it mostly works, but it is possible to occasionally get double controls.

the loadVideoById doesn't seem to work inside the videojs.Youtube.prototype.src

I dont understand this part, but hopefully the example will help. If not LMK.

[mzaky]

Hi all,

could someone help:

function loadVideo(playerUrl, offset) {

var ytURL = playerUrl.split('?')[0];
var vtype = 'video/youtube';
//document.getElementById('v1').innerHTML = html.join('');
// declare object for video

     var player;

     videojs('vid1',{
        techOrder:['html5', "flash", "youtube", 'vimeo'],    
     },function(){ 

        //console.log(' -> VideoJS ready for id: ');
        player = this;
     });

     player.src({
           type: vtype,
           src: ytURL
        }); 

}

if I call this function through, i don't get the video updated:
loadVideo(playerUrl, true)

[ulisesrmzroche]

@eXon, @tomsaffell , so, what's up with this feature? I'd like to use this today. I can finish the rest of it if ya'll want.

[eXon]

@ulisesrmzroche @mzaky @tomsaffell @OmniTool Now this should work. Let me know if you see any bug.

[ulisesrmzroche]

@eXon, nice! This is shaping up to be a great morning.