Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document playbackRates #71

Open
edemaine opened this issue Sep 4, 2017 · 2 comments
Open

Document playbackRates #71

edemaine opened this issue Sep 4, 2017 · 2 comments

Comments

@edemaine
Copy link

edemaine commented Sep 4, 2017

The Video.js Options Reference should mention the option playbackRates and how to use it. I only found out about it because of this StackOverflow post. (FWIW, I wrote and shared a now-very-old plugin video-speed.js which may have inspired this feature. Very happy to find this included in the modern base video.js!)

@misteroneill
Copy link
Member

Ah, yes, it should be documented. As far as the feature is concerned, I'm pretty sure it comes from the DOM API. We'd definitely welcome a PR to the options guide, if you're feeling up for it!

@edemaine
Copy link
Author

edemaine commented Sep 6, 2017

The DOM supports playbackRate to change/get the current playback rate, but video.js specifically supports options of {playbackRates: ...} which causes the creation of a widget to select playback rate. I'll take a stab at a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants