Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document playbackRates #4602

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Document playbackRates #4602

merged 1 commit into from
Sep 19, 2017

Conversation

edemaine
Copy link
Contributor

@edemaine edemaine commented Sep 6, 2017

Description

Add documentation for the already supported playbackRates option, based on my experience and this StackOverflow post.

Fix to videojs/videojs.com#71 (sorry, I probably put that in the wrong repo of the same org).

Specific Changes proposed

  • New section in docs/guides/options.md describing playbackRates

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

gkatsev
gkatsev approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@gkatsev gkatsev merged commit 9d249bb into videojs:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@brandonocasey brandonocasey brandonocasey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edemaine @gkatsev @brandonocasey