This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
fix: escape quotes in moduleIds to support webpack loaders #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecotne
reviewed
Mar 15, 2018
| @@ -188,10 +188,11 @@ var bundleWithWebpack = function(fn, fnModuleId) { | |||
| var modulesString; | |||
|
|
|||
| if (devMode) { | |||
| fnModuleId = '"' + fnModuleId + '"'; | |||
| // must escape quotes to support webpack loader options | |||
| fnModuleId = '"' + fnModuleId.replace(/"/g, '\\\"') + '"'; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah good call, that is nicer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack loaders can be activated with options that may contain quotes
"e.g.
import style from 'css-loader?{"key":"value"}!style.css';This change makes sure to escape any quotes in module ids so valid javascript is output
Address issue found here videojs/videojs-contrib-hls#600 (comment)