GTK# / Xamarin.Forms.Gtk implementations (reloaded) #20

jeremyVignelles · 2018-11-14T21:35:50Z

replaces #2
Due to the recent changes in the libvlcsharp, too many conflicts prevented the proper merge of #2.

This is a new, better implementation. It should fix cross-platform build issues, but it still needs to be confirmed. (My msbuild on my linux has been broken by an update : mono/linux-packaging-msbuild#8 )

Forms.GTK# also works! The initialization bug does not affect us anymore due to the fact that the media player is now given externally.

Checklist

Write the code for the Gtk# implementation
Write the code for Xamarin.Forms using the GTK# backend
Make it work on Windows
Make it work on Linux
Make it work on MacOS
Check that the Forms.Gtk sample works on all three platforms
Write installation instructions on all 3 platforms

/cc @mfkl @Ch4rg3r

mfkl · 2018-11-15T01:28:47Z

Well done!

LibVLCSharp.Gtk/VideoView.cs

mfkl · 2018-11-15T03:38:20Z

libvlcsharp/LibVLCSharp/Shared/Core.cs

Line 157 in 1c0655b

get => (int)Environment.OSVersion.Platform == 6;

returns 4 (Unix) on macOS. Only way around it is to start a new process and check for the name "darwin", ugh

mfkl · 2018-11-15T04:06:59Z

This fails on GTK.Mac

libvlcsharp/LibVLCSharp/Shared/Core.cs

Line 132 in 1c0655b

return IsMac ? Native.dlopen(libraryPath) : Native.LoadLibrary(libraryPath);

No idea why, no logs... same libvlc gets loaded fine in the Xamarin.Mac Cocoa sample, and I got it working before... meh

LibVLCSharp.Gtk/VideoView.cs

jeremyVignelles · 2018-11-15T06:25:26Z

For your two remarks about mac, I just copy-pasted what you did, I didn't really understand.
== 6 seems magic, while there is an enum value (see what I did on linux)

mfkl · 2018-11-15T08:38:41Z

== 6 seems magic, while there is an enum value (see what I did on linux)

It was needed magic, unfortunately it does not work. https://github.com/dotnet/corefx/issues/19694
NET Classic minimum supported target on Mac will be net471

mfkl · 2018-11-15T08:44:12Z

libvlc for mac seems to be included 1/2 times when rebuilding... weird. Always fine with netcore targets
I managed to build and run the sample on mac, only from CLI. Running with VS is not possible as the dylib is not copied to output (but building with CLI it is, most of the time)
dlopen of libvlc on Linux is missing.
And last but not least, here's a weird one: The second I touch the GTK videoview on mac with the mouse cursor, it crashes with

Stack overflow in unmanaged: IP: 0x107261f69, fault addr: 0x7ffeec73eff8
Stack overflow: IP: 0x107261f69, fault addr: 0x7ffeec735ff8
Stacktrace:
  at <unknown> <0xffffffff>
  at Gtk.Application.Run () [0x00001] in /Users/builder/jenkins/workspace/build-package-osx-mono/2018-02/external/bockbuild/builds/gtk-sharp-None/gtk/Application.cs:145
  <...>
  at LibVLCSharp.GTK.Sample.Program.Main () [0x0009d] in /Users/Martz/Projects/LibVLCSharp/Samples/LibVLCSharp.GTK.Sample/Program.cs:35
  at (wrapper runtime-invoke) object.runtime_invoke_void (object,intptr,intptr,intptr) [0x0004d] in <71f4e3d7d65e42b0a699d02e59766d3c>:0

jeremyVignelles · 2018-11-15T20:34:34Z

Merged @mfkl 's suggestions into my branch and rebased / squashed the commits.

@mfkl : What's left to do on your side with Mac?

For linux, everything builds fine thanks to instructions here : mono/linux-packaging-msbuild#7, but I still can't build the Forms.Gtk.Sample :

Microsoft (R) Build Engine version 15.8.0.0 ( Thu Nov 15 18:28:44 CET 2018) pour Mono
Copyright (C) Microsoft Corporation. Tous droits réservés.

La génération a démarré 15/11/2018 21:29:31.
Projet "/data/projects/dotnet/libvlcsharp/Samples/Forms/LibVLCSharp.Forms.Sample.GTK/LibVLCSharp.Forms.Sample.GTK.csproj" sur le nœud 1 (cibles par défaut).
/data/projects/dotnet/libvlcsharp/Samples/Forms/LibVLCSharp.Forms.Sample.GTK/LibVLCSharp.Forms.Sample.GTK.csproj(151,5): error : Ce projet fait référence à des packages NuGet qui sont manquants sur cet ordinateur. Utilisez l'option de restauration des packages NuGet pour les télécharger. Pour plus d'informations, consultez http://go.microsoft.com/fwlink/?LinkID=322105. Le fichier manquant est : ../../../packages/Xamarin.Forms.3.2.0.871581/build/netstandard2.0/Xamarin.Forms.props.
Génération du projet "/data/projects/dotnet/libvlcsharp/Samples/Forms/LibVLCSharp.Forms.Sample.GTK/LibVLCSharp.Forms.Sample.GTK.csproj" terminée (cibles par défaut) -- ÉCHEC.

ÉCHEC de la build.

"/data/projects/dotnet/libvlcsharp/Samples/Forms/LibVLCSharp.Forms.Sample.GTK/LibVLCSharp.Forms.Sample.GTK.csproj" (cible par défaut) (1) ->
(EnsureNuGetPackageBuildImports cible) -> 
  /data/projects/dotnet/libvlcsharp/Samples/Forms/LibVLCSharp.Forms.Sample.GTK/LibVLCSharp.Forms.Sample.GTK.csproj(151,5): error : Ce projet fait référence à des packages NuGet qui sont manquants sur cet ordinateur. Utilisez l'option de restauration des packages NuGet pour les télécharger. Pour plus d'informations, consultez http://go.microsoft.com/fwlink/?LinkID=322105. Le fichier manquant est : ../../../packages/Xamarin.Forms.3.2.0.871581/build/netstandard2.0/Xamarin.Forms.props.

    0 Avertissement(s)
    1 Erreur(s)

Temps écoulé 00:00:00.45

It tells me it can't find ../../../packages/Xamarin.Forms.3.2.0.871581/build/netstandard2.0/Xamarin.Forms.props, despite having run msbuild /t:Restore, which does nothing (or at least doesn't install anything at the path specified). Any idea @jsuarezruiz ?

LibVLCSharp.Forms.Platforms.GTK/LibVLCSharp.Forms.Platforms.GTK.csproj

Samples/Forms/LibVLCSharp.Forms.Sample.GTK/LibVLCSharp.Forms.Sample.GTK.csproj

mfkl · 2018-11-19T09:37:16Z

@mfkl : What's left to do on your side with Mac?

The stackoverflow when the mouse cursor touches the GTK DrawingArea would be the last blocker.

The rest is just annoying but we can ship without (CLI only, VS4Mac crashes when editing GTK projects).
I have tried a few things on the libvlc side (i.e. mp.EnableMouseInput false/true) and on the GTK side but no clue... Have to use gdb.
Note that I can grab and move the window no problem, it crashes only when the cursor comes in contact with the DrawingArea.

For linux, can you write a small instruction guide to get proper libvlc (for ubuntu at least) and whatever else is needed to get the sample running? Will add it to the gitlab wiki page.

LibVLCSharp.Forms.Platforms.GTK/LibVLCSharp.Forms.Platforms.GTK.csproj

jeremyVignelles · 2019-01-02T21:58:47Z

I managed to make the Xamarin.Forms sample work on linux: I fixed the project reference path (linux is case-sensitive) and restored the packages with nuget install -OutputDirectory ../../../packages in the Samples/Forms/LibVLCSharp.Forms.Sample.GTK folder.

It works well, but it's quite manual. Shall we switch to a SDK-style project instead? Shall we make a template project?

mfkl · 2019-01-03T02:23:52Z

Shall we switch to a SDK-style project instead?

Sure. Are you saying that would help fix the manual restore part?

Shall we make a template project?

Not sure what you mean. Sample project?

jeremyVignelles · 2019-01-03T06:13:52Z

Sure. Are you saying that would help fix the manual restore part?

I guess: instead of nuget install, dotnet build automatically restores the packages. I need to test if it works

Not sure what you mean. Sample project?

A repo project that can be used to dotnet new VideoLAN.LibVLCSharp.Forms.GTK. I need to look how it works.

This makes it easier to consume (`msbuild /t:Restore`, `msbuild`)

jeremyVignelles · 2019-01-17T22:11:55Z

Current status: Almost done. ✔️

Remaining:

GTK# stackoverflows on mac due to GTK# stackoverflow mac mono/gtk-sharp#257 , will probably release with the bug...
Docs
More docs
Squash
Merge 🎉

jbkempf · 2019-01-20T15:34:39Z

I'd argue you should merge without macOS for now.

mfkl · 2019-01-20T17:23:24Z

I'd argue you should merge without macOS for now.

That's the plan.

mfkl · 2019-01-21T03:32:15Z

Merged a927af5.

Good job 👍

jeremyVignelles mentioned this pull request Nov 14, 2018

GTK# / Xamarin.Forms.Gtk implementations #2

Closed

10 tasks

mfkl reviewed Nov 15, 2018

View reviewed changes

LibVLCSharp.Gtk/VideoView.cs Outdated Show resolved Hide resolved

mfkl reviewed Nov 15, 2018

View reviewed changes

LibVLCSharp.Gtk/VideoView.cs Outdated Show resolved Hide resolved

jeremyVignelles commented Nov 15, 2018

View reviewed changes

LibVLCSharp.Gtk/VideoView.cs Outdated Show resolved Hide resolved

jeremyVignelles force-pushed the feature/gtk-sharp-reloaded branch from cc4ed45 to 8179532 Compare November 15, 2018 20:25

mfkl reviewed Nov 19, 2018

View reviewed changes

LibVLCSharp.Forms.Platforms.GTK/LibVLCSharp.Forms.Platforms.GTK.csproj Outdated Show resolved Hide resolved

mfkl reviewed Nov 19, 2018

View reviewed changes

Samples/Forms/LibVLCSharp.Forms.Sample.GTK/LibVLCSharp.Forms.Sample.GTK.csproj Outdated Show resolved Hide resolved

jeremyVignelles force-pushed the feature/gtk-sharp-reloaded branch 2 times, most recently from 0f21261 to f55b986 Compare December 1, 2018 12:02

mfkl reviewed Dec 1, 2018

View reviewed changes

LibVLCSharp.Forms.Platforms.GTK/LibVLCSharp.Forms.Platforms.GTK.csproj Outdated Show resolved Hide resolved

jeremyVignelles force-pushed the feature/gtk-sharp-reloaded branch from f55b986 to e07ad19 Compare January 2, 2019 21:49

mfkl mentioned this pull request Jan 3, 2019

GTK# stackoverflow mac mono/gtk-sharp#257

Open

jeremyVignelles added 3 commits January 17, 2019 22:46

GTK# implementation

ed9878c

Fixed MacOS gtk-sharp path

e1c37bb

Transformed Forms.Sample.GTK to a sdk-style csproj

e50ea98

This makes it easier to consume (`msbuild /t:Restore`, `msbuild`)

jeremyVignelles force-pushed the feature/gtk-sharp-reloaded branch from 72b2add to e50ea98 Compare January 17, 2019 22:05

mfkl added 2 commits January 19, 2019 16:42

setup libvlcsharp.gtk csproj

5e9da5c

GTK VideoView: Add comments

bc0ca7a

mfkl and others added 8 commits January 19, 2019 16:42

remove linux compilation directive: runtime check is enough

7bf66fc

Linux - XInitThreads: use Trace instead of Debug in case of failure

441008e

remove the GTK VideoView optional parameter

d2571a9

fix GTK sample: set MediaPlayer property and exit gracefully

9c1fc81

nitpick: GTK.Forms sample

ffce096

setup libvlcsharp.forms.gtk

ca51310

add initial linux getting started doc

027bb03

Updated linux documentation

5b00386

mfkl closed this Jan 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GTK# / Xamarin.Forms.Gtk implementations (reloaded) #20

GTK# / Xamarin.Forms.Gtk implementations (reloaded) #20

jeremyVignelles commented Nov 14, 2018 •

edited

mfkl commented Nov 15, 2018

mfkl commented Nov 15, 2018

mfkl commented Nov 15, 2018

jeremyVignelles commented Nov 15, 2018

mfkl commented Nov 15, 2018 •

edited

mfkl commented Nov 15, 2018

jeremyVignelles commented Nov 15, 2018

mfkl commented Nov 19, 2018 •

edited

jeremyVignelles commented Jan 2, 2019

mfkl commented Jan 3, 2019

jeremyVignelles commented Jan 3, 2019 •

edited

jeremyVignelles commented Jan 17, 2019 •

edited

jbkempf commented Jan 20, 2019

mfkl commented Jan 20, 2019

mfkl commented Jan 21, 2019

GTK# / Xamarin.Forms.Gtk implementations (reloaded) #20

GTK# / Xamarin.Forms.Gtk implementations (reloaded) #20

Conversation

jeremyVignelles commented Nov 14, 2018 • edited

mfkl commented Nov 15, 2018

mfkl commented Nov 15, 2018

mfkl commented Nov 15, 2018

jeremyVignelles commented Nov 15, 2018

mfkl commented Nov 15, 2018 • edited

mfkl commented Nov 15, 2018

jeremyVignelles commented Nov 15, 2018

mfkl commented Nov 19, 2018 • edited

jeremyVignelles commented Jan 2, 2019

mfkl commented Jan 3, 2019

jeremyVignelles commented Jan 3, 2019 • edited

jeremyVignelles commented Jan 17, 2019 • edited

jbkempf commented Jan 20, 2019

mfkl commented Jan 20, 2019

mfkl commented Jan 21, 2019

jeremyVignelles commented Nov 14, 2018 •

edited

mfkl commented Nov 15, 2018 •

edited

mfkl commented Nov 19, 2018 •

edited

jeremyVignelles commented Jan 3, 2019 •

edited

jeremyVignelles commented Jan 17, 2019 •

edited