Player: Swipe to minimize #456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decreases the distance you have to swipe to minimize both PlayerViewController and VideoPlayerViewController
This patch makes it so that you can swipe down from the middle of the screen to minimize the player. If the volume/brightness gesture are disabled, you're able to swipe down from anywhere on screen.
|
Thanks a lot for your pull request, which is a very nice improvement! We cannot merge it here, so I created a merge request on our own gitlab instance here: https://code.videolan.org/videolan/vlc-ios/-/merge_requests/1092 You are very welcome to continue contributing to our project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adjusts the distance you have to swipe to minimize the
player from 50% of the view height to 10%, making it significantly
easier minimize the player.
This patch also makes it so that you can swipe down from the middle
of the screen to minimize the player. If the volume/brightness gestures
are disabled, you're able to swipe down from anywhere on the screen.
Before
After