Fix several bugs (duplicate load media, media listeners bug, etc) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Media update listeners always return isAlive to false. This.fix the bug.
New Fixes added.
Erased comment
|
Sorry, but how can i add a last change to the pull request? |
matbee-eth
added a commit
that referenced
this pull request
Dec 23, 2014
Fix several bugs (duplicate load media, media listeners bug, etc)
|
All you have to do is send a new Pull Request |
|
It's ok. Greetings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This pull request has several arrangements.
It has been tested with Chrome sender apps from Google as "hello-video" and "cast-videos".
In "chrome.cast.js" line 531 caused to be invoked twice the load of video.
Media update listeners were not recovering the isAlive parameter.
Have adapted the classes methods to fit the parameters expected.
In "ChromecastSession.java", MediaChannelResult callback is not where it should invoke "onMediaLoaded" listener but in the onSuccess of your getStatus. Now "mediaLoaded" has an active session.
Sorry my bad english, hope I explained clearly.
Thanks for your great plugin.