Package manager tests #75
Conversation
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
============================================
+ Coverage 62.57% 66.36% +3.78%
- Complexity 123 130 +7
============================================
Files 24 24
Lines 660 663 +3
Branches 65 66 +1
============================================
+ Hits 413 440 +27
+ Misses 216 189 -27
- Partials 31 34 +3
Continue to review full report at Codecov.
|
|
great, thank you for submitting this pr and contributing to the project! |
| if (!name.equals(that.name)) return false; | ||
|
|
||
| return true; | ||
| } |
There was a problem hiding this comment.
Only very few parts of this function is tested, I think thats why codecov bails out. Are all these checks really needed? Specifically, the check for class equality will cause problems in case someone subclasses Package, right? Also the last two statements can just be written as
return name.equals(that.name);
To avoid a branch that would otherwise need to be tested.
There was a problem hiding this comment.
Also on line 26 there is a bit too much whitespace. I think just dropping this change is the easiest way to get the tests to pass.
|
hmm, codecov/path still fails, but 🤷♂️ thank you very much! And congrats to first pr. 🎉 |
|
Was just writing a message. Thanks for sharing your project :) |
Fixing #72 for the primary method in PackageManager.
Altering the equals method of Package for testing value equality.