Fix: Made method async to fix promise warning

vieira · Jan 4, 2020 · d9fe7dc · d9fe7dc
1 parent 8fbf288
commit d9fe7dc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/bulbs/bulb.js b/bulbs/bulb.js
@@ -87,7 +87,7 @@ class YeeBulb {
       .updateValue(this.power);
   }
 
-  setPower(power) {
+  async setPower(power) {
     if (this.power === power) {
       return Promise.resolve(power);
     }
@@ -97,9 +97,8 @@ class YeeBulb {
       method: 'set_power',
       params: [state, 'smooth', transition],
     };
-    return this.sendCmd(req).then(() => {
-      this._power = power;
-    });
+    await this.sendCmd(req);
+    this._power = power;
   }
 
   connect() {

diff --git a/bulbs/color.js b/bulbs/color.js
@@ -78,13 +78,13 @@ const Color = Device => {
       super.updateStateFromProp(prop, value);
     }
 
-    setColor(hv, sv) {
+    async setColor(hv, sv) {
       hue = isInteger(hue) ? hue : hv;
       sat = isInteger(sat) ? sat : sv;
       if (!isInteger(hue) || !isInteger(sat)) return Promise.resolve();
 
       const { color: transition = 1500 } = this.config.transitions || {};
-      this.setPower(1);
+      await this.setPower(1); // TODO: Why do we need to switch on the lamp here?
       const req = {
         method: 'set_hsv',
         params: [hue, sat, 'smooth', transition],