Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish and document the generator's code #25

Closed
ptillet opened this issue May 17, 2013 · 4 comments
Closed

Polish and document the generator's code #25

ptillet opened this issue May 17, 2013 · 4 comments
Assignees

Comments

@ptillet
Copy link
Collaborator

ptillet commented May 17, 2013

The generator is merged in the master branch, but the code can still be polished (some base classes to introduce, dirty code to remove ...) and is yet to be documented.

@ghost ghost assigned ptillet May 17, 2013
@karlrupp
Copy link
Collaborator

Ok, fine, small-grained issues have higher chances of being closed soon ;-)

@ptillet
Copy link
Collaborator Author

ptillet commented May 18, 2013

yes, sort of ;)
I have merged files together, renamed classes and added comments for the symbolic objects. I will add more comments and clean it when I have time (4500lines of code is long to document!).
If you need heavy documentation on some particular classes, methods, just ask me and I'll do it right away! ;)

@karlrupp
Copy link
Collaborator

One related thing: I noticed that after the merge the compilation is no longer clean with -Wall -pedantic. Also, I once fixed the old generator such that -Wextra works (non-CUDA, since nvcc produces tons of warnings here) - could you please fix this?

@ptillet
Copy link
Collaborator Author

ptillet commented May 19, 2013

done :)

2013/5/19 Karl Rupp notifications@github.com

One related thing: I noticed that after the merge the compilation is no
longer clean with -Wall -pedantic. Also, I once fixed the old generator
such that -Wextra works (non-CUDA, since nvcc produces tons of warnings
here) - could you please fix this?


Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-18111065
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants