Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a few implicit conversion warnings #50

Merged
merged 1 commit into from
Nov 28, 2013
Merged

Conversation

albertz
Copy link
Contributor

@albertz albertz commented Nov 28, 2013

This fixes all warnings I currently have (as described in #49).

@karlrupp
Copy link
Collaborator

Thanks, Albert. Just for reference, could you just comment on the compiler you used to get these warnings? I don't get these with the set of compilers I regularly test.

karlrupp added a commit that referenced this pull request Nov 28, 2013
fix a few implicit conversion warnings
@karlrupp karlrupp merged commit 87f6d2b into viennacl:master Nov 28, 2013
@albertz
Copy link
Contributor Author

albertz commented Nov 28, 2013

It was wir Clang 5.0.0. But I was using Xcode in this case which enables quite a few more warning flags by default. The full compile command was:

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -x c++ -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu++11 -stdlib=libc++ -Wno-trigraphs -fpascal-strings -O0 -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Werror=deprecated-objc-isa-usage -Werror=objc-root-class -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wshorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DDEBUG=1 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.9 -g -fvisibility-inlines-hidden -Wno-sign-conversion -iquote /Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/NN-OCR.build/Debug/NN-OCR.build/NN-OCR-generated-files.hmap -I/Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/NN-OCR.build/Debug/NN-OCR.build/NN-OCR-own-target-headers.hmap -I/Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/NN-OCR.build/Debug/NN-OCR.build/NN-OCR-all-target-headers.hmap -iquote /Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/NN-OCR.build/Debug/NN-OCR.build/NN-OCR-project-headers.hmap -I/Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/Debug/include -I/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include -I/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include -I/usr/local/include -I/Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/NN-OCR.build/Debug/NN-OCR.build/DerivedSources/x86_64 -I/Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/NN-OCR.build/Debug/NN-OCR.build/DerivedSources -F/Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/Debug -MMD -MT dependencies -MF /Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/NN-OCR.build/Debug/NN-OCR.build/Objects-normal/x86_64/mathutils.d --serialize-diagnostics /Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/NN-OCR.build/Debug/NN-OCR.build/Objects-normal/x86_64/mathutils.dia -c /Users/az/Programmierung/NeuralNets/NN-OCR/mathutils.cpp -o /Users/az/Programmierung/NeuralNets/NN-OCR/mac/build/NN-OCR.build/Debug/NN-OCR.build/Objects-normal/x86_64/mathutils.o

@karlrupp
Copy link
Collaborator

Thanks, Albert, I'll look out for a test machine with Clang 5.0.0 then :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants