Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycling of tabs is broken (in new browser) #1655

Closed
barijaona opened this issue Jan 21, 2023 · 1 comment
Closed

Cycling of tabs is broken (in new browser) #1655

barijaona opened this issue Jan 21, 2023 · 1 comment
Assignees

Comments

@barijaona
Copy link
Member

Describe the bug
Vienna had a round robin feature when navigating through "previous tab/next tab".
This is currently broken in new browser.

To Reproduce
1/ When you are on the first tab (the "Articles" tab), select the "Window→Previous Tab" menu item (or use its keyboard equivalent Command-Option-LeftArrow).
Nothing happens while this should bring you to the rightmost tab.
2/ similarly, when you are on rightmost tab, nothing happens when you select the "Window→Next Tab" menu item (or using its keyboard equivalent Command-Option-RightArrow). This should bring you to the first tab.
3/ the bug only appears when "Preview New Browser" is activated (in the Advanced section of Vienna's settings / preferences).
When you use the old browser, things are working as expected.

Please complete the following information:

  • Vienna 3.8.0 and up

Additional information:

@barijaona barijaona self-assigned this Jan 21, 2023
barijaona added a commit to barijaona/vienna-rss that referenced this issue Jan 21, 2023
"Previous Tab / Next Tab" menu commands should cycle between open tabs,
handling transitions between last tab and first tab when respective ends
are reached.

https://forums.cocoaforge.com/viewtopic.php?f=18&t=27266&p=141046
Issue ViennaRSS#1655
barijaona added a commit that referenced this issue Jan 21, 2023
"Previous Tab / Next Tab" menu commands should cycle between open tabs,
handling transitions between last tab and first tab when respective ends
are reached.

Cherry-picked from 52d948b

https://forums.cocoaforge.com/viewtopic.php?f=18&t=27266&p=141046
Issue #1655
@barijaona
Copy link
Member Author

Fixed in 3.8.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant