Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntityRepository::searchIds does not throw ShopwareSearchResponseException #49

Closed
TobiasGraml11 opened this issue Sep 7, 2022 · 3 comments
Closed

EntityRepository::searchIds does not throw ShopwareSearchResponseException #49

TobiasGraml11 opened this issue Sep 7, 2022 · 3 comments
Assignees
@vienthuong
Labels
enhancement New feature or request

Comments

@TobiasGraml11
Copy link
Contributor

TobiasGraml11 commented Sep 7, 2022 •
edited
Loading

I am implementing an exception handling regarding missing privileges.

During this, I noticed that EntityRepository::search does throw a ShopwareSearchResponseException, in case Guzzle returns a BadResponseException.
I would expect the same from EntityRepository::searchIds, as the exception could also occur there.

In my example the missing privilege was a manufacturer filter for the product.

image

image

Cheers!
@vienthuong vienthuong self-assigned this Sep 7, 2022
@vienthuong vienthuong added the enhancement New feature or request label Sep 7, 2022
@vienthuong
Copy link
Owner

I will take care of it, thanks for reporting :)

@TobiasGraml11
Copy link
Contributor Author

@vienthuong Thanks!

@vienthuong
Copy link
Owner

Sorry for the late response
I fixed this in latest 1.7.2 version, feel free to reopen if you have any issue with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vienthuong vienthuong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vienthuong @TobiasGraml11