Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove entity hydration cache, add hydration logic via DI #47

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Remove entity hydration cache, add hydration logic via DI #47

merged 2 commits into from
Sep 7, 2022

Conversation

ckilb
Copy link

@ckilb ckilb commented Aug 30, 2022 •
edited
Loading

  • The logic to store previous entity hydrations in some cache array was removed without replacement
  • All usages of EntityTrait replaced with a new class src/Hydrate/EntityHydrator.php. New class can be injected via DI.

Related issue: #46

@ckilb ckilb mentioned this pull request Aug 30, 2022
Closed
@ckilb ckilb force-pushed the master branch 2 times, most recently from c590d26 to 7454a5b Compare August 30, 2022 09:27
@vienthuong
Copy link
Owner

vienthuong commented Sep 7, 2022 •
edited
Loading

@ckilb Please solve the conflict

@vienthuong vienthuong self-requested a review September 7, 2022 14:10
@ckilb
Copy link
Author

ckilb commented Sep 7, 2022

@ckilb Please solve the conflict

done

@vienthuong vienthuong merged commit 20be793 into vienthuong:master Sep 7, 2022
@vienthuong vienthuong mentioned this pull request Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vienthuong vienthuong Awaiting requested review from vienthuong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckilb @vienthuong