Skip to content

Commit

Permalink
Merge pull request #232 from vierge-noire/next
Browse files Browse the repository at this point in the history
v3.0.1
  • Loading branch information
pabloelcolombiano committed Oct 11, 2023
2 parents e63e59d + e9aee90 commit ce853e2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/Command/BakeFixtureFactoryCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ public function templateData(Arguments $arg): array
$data['useStatements'] = array_unique(array_values(Hash::flatten($useStatements)));
}

if ($data['useStatements']) {
if (!empty($data['useStatements'])) {
foreach ($data['useStatements'] as $index => $useStatement) {
$nameSpaceCheck = str_replace($data['namespace'] . '\\', '', $useStatement);
if (!str_contains($nameSpaceCheck, '\\')) {
Expand Down Expand Up @@ -420,6 +420,8 @@ public function getOptionParser(): ConsoleOptionParser
$name = ($this->plugin ? $this->plugin . '.' : '') . $this->name;
$parser = new ConsoleOptionParser($name);

$parser = $this->_setCommonOptions($parser);

$parser->setDescription(
'Fixture factory generator.'
)
Expand Down
6 changes: 6 additions & 0 deletions tests/TestCase/Command/BakeFixtureFactoryCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -343,4 +343,10 @@ public function testThisTableShouldBeBaked(string $model, $plugin, bool $expecte

$this->assertSame($expected, $this->FactoryCommand->thisTableShouldBeBaked($model, $this->io));
}

public function testCommandHasCommonOptions()
{
$options = $this->FactoryCommand->getOptionParser()->toArray();
$this->assertArrayHasKey('connection', $options['options']);
}
}

0 comments on commit ce853e2

Please sign in to comment.