Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpdoc @param types of FactoryAwareTrait::getFactory() is too narrower than acceptable types #218

Closed
ckbx-cakebox opened this issue Aug 13, 2023 · 1 comment
Closed

phpdoc @param types of FactoryAwareTrait::getFactory() is too narrower than acceptable types #218

ckbx-cakebox opened this issue Aug 13, 2023 · 1 comment

Comments

@ckbx-cakebox
Copy link
Contributor

The second and trailing arguments of FactoryAwareTrait::getFactory() can internally accept as same types as the BaseFactory::make(), but currently declared as a sequence of array[]|string in phpdoc. It cannot accept even the simple associative array, that is one of the main use cases.
This was referenced Aug 13, 2023
Merged
Merged
pabloelcolombiano added a commit that referenced this issue Aug 22, 2023
@pabloelcolombiano
Merge pull request #219 from ckbx-cakebox/#218-factory-aware-trait-ar…
8444666 
…gument-types

#218 Match argument types of FactoryAwareTrait::getFactory() as BaseFactory::make()
pabloelcolombiano added a commit that referenced this issue Aug 22, 2023
@pabloelcolombiano
Merge pull request #220 from ckbx-cakebox/#218-bake-factory-with-argu…
b68d5e7 
…ment-types

#218 fix phpdoc argument types of the with* methods inside bake factory template
@pabloelcolombiano
Copy link
Collaborator

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckbx-cakebox @pabloelcolombiano