Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @internal from FactoryTableRegistry class #223

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Remove @internal from FactoryTableRegistry class #223

merged 1 commit into from
Sep 14, 2023

Conversation

ishanvyas22
Copy link
Contributor

@ishanvyas22 ishanvyas22 commented Sep 12, 2023 •
edited
Loading

There are times when package users needs to clear table registry, so it is better to not have @internal in the FactoryTableRegistry class.

pabloelcolombiano
pabloelcolombiano approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@pabloelcolombiano pabloelcolombiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!

@pabloelcolombiano pabloelcolombiano merged commit 375a26c into vierge-noire:main Sep 14, 2023
28 checks passed
@ishanvyas22 ishanvyas22 deleted the remove-internal branch September 14, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloelcolombiano pabloelcolombiano pabloelcolombiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ishanvyas22 @pabloelcolombiano