Skip to content

Commit

Permalink
fix-Process-Create-options-Unused
Browse files Browse the repository at this point in the history
```
    static ProcessBuilder create(Vertx vertx, String command, ProcessOptions options) {
        return create(vertx, command, Collections.emptyList(), new ProcessOptions());
    }
```

I've identified a bug in the create method of the ProcessBuilder class. The method signature suggests that it should use the ProcessOptions options parameter provided by the caller. However, in the current implementation, the method disregards this parameter and instead creates a new ProcessOptions object. This behavior could lead to unexpected issues, as any custom configurations passed through the options parameter are not being utilized.
  • Loading branch information
aruis authored and vietj committed Jan 12, 2024
1 parent 8acd4dd commit a4ec811
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/com/julienviet/childprocess/Process.java
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ static ProcessBuilder create(Vertx vertx, String command, List<String> args) {
* @return the created child process
*/
static ProcessBuilder create(Vertx vertx, String command, ProcessOptions options) {
return create(vertx, command, Collections.emptyList(), new ProcessOptions());
return create(vertx, command, Collections.emptyList(), options);
}

/**
Expand Down

0 comments on commit a4ec811

Please sign in to comment.