Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bash-completion for bidirectional "docker cp" #6

Merged
merged 1 commit into from
Jun 25, 2014

Conversation

tianon
Copy link

@tianon tianon commented Jun 25, 2014

No description provided.

Docker-DCO-1.1-Signed-off-by: Andrew Page <admwiggin@gmail.com> (github: tianon)
@vieux
Copy link
Owner

vieux commented Jun 25, 2014

LGTM

@vieux vieux merged this pull request into vieux:cp_scp Jun 25, 2014
@tianon tianon deleted the scp-bash-completion branch June 25, 2014 22:03
@tianon
Copy link
Author

tianon commented Jun 29, 2014

I think this might have gotten lost somewhere - I don't see it in the PR. Should I PR it again?

@vieux
Copy link
Owner

vieux commented Jun 30, 2014

@tianon I merged it, don't you see the commits on my PR ?

@tianon
Copy link
Author

tianon commented Jun 30, 2014

Nope, I'm looking at https://github.com/dotcloud/docker/pull/6580/commits and I don't see them there. :/

@tianon
Copy link
Author

tianon commented Jun 30, 2014

Also, looking at 7c05425 it doesn't show the commit being part of any branches.

@vieux
Copy link
Owner

vieux commented Jul 1, 2014

ah maybe I forced pushed :?

can you reopen a pr ?

On Mon, Jun 30, 2014 at 4:23 PM, Tianon Gravi notifications@github.com
wrote:

Also, looking at 7c05425
7c05425
it doesn't show the commit being part of any branches.


Reply to this email directly or view it on GitHub
#6 (comment).

Victor VIEUX
http://vvieux.com

@tianon tianon restored the scp-bash-completion branch July 1, 2014 00:29
@tianon
Copy link
Author

tianon commented Jul 1, 2014

(for posterity, see #8)

@vieux
Copy link
Owner

vieux commented Jul 1, 2014

done

On Mon, Jun 30, 2014 at 5:33 PM, Tianon Gravi notifications@github.com
wrote:

(for posterity, see #8 #8)


Reply to this email directly or view it on GitHub
#6 (comment).

Victor VIEUX
http://vvieux.com

vieux pushed a commit that referenced this pull request Sep 23, 2014
Benchmark for StdWriter.Write
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants