Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Releasing new version #298

Closed
pomali opened this issue Aug 25, 2023 · 13 comments
Closed

Releasing new version #298

pomali opened this issue Aug 25, 2023 · 13 comments

Comments

@pomali
Copy link

pomali commented Aug 25, 2023

I would love having new version with fixes for django 4.1+ (eg. #289). It would greatly simplify my dependency management :)

Is there anything I can do to help with new release?

@pmyjavec
Copy link

Is this project dead? I'm guessing so?

@kmmbvnr
Copy link
Collaborator

kmmbvnr commented Oct 24, 2023

It's replaced by Django-viewflow fsm module https://docs.viewflow.io/fsm/index.html

@pmyjavec
Copy link

@kmmbvnr ok so we should migrate away from this project altogether ?

Any reason why this project still exists and is not archived, maybe not a bad idea to update the README.md?

@ds-clearago
Copy link

ds-clearago commented Oct 26, 2023

I'm also not clear as to what's going to happen to this library. Looking at the Readme of this and viewflow, it seemed like django-fsm is still being developed in parallel as the open source limited features variant of paid viewflow. But the above statement sounds very different.

Does that mean that what's already in master but not released yet (e.g. django4 fixes, see 2.8.1...master) or PRs like #297 are never going to be merged and released within this library and that starting a new project with django-fsm is not a good idea since it's effectively deprecated and instead people should be moving to viewflow?

Or are you @kmmbvnr going to focus your personal time and effort on viewflow (since this rewards your time with the license fee)? Is this repo then going to be archived or is this library potentially going to move to https://jazzband.co/ (where django-fsm-log already is maintained)?

I'm about to start django-fsm using this productively in a commercial project, so clarity is important also to make a decision whether it makes sense to look at viewflow and potentially even pay for it.
But a lack of clarity of the relation between django-fsm and viewflow and viewflow pro and the future of both projects definitely does not help to create the trust needed for effectively buying a subscription (see https://viewflow.io/pro.html) – even though I'd very much consider it given all information.

Thanks for your efforts on all these projects that are helping countless developers, really looking forward to better understand what your plan is @kmmbvnr
Thanks!

@ds-clearago
Copy link

@kmmbvnr Can you please elaborate on your plans with https://github.com/viewflow/django-fsm vs. https://docs.viewflow.io/fsm/index.html (https://github.com/viewflow/viewflow/tree/main/viewflow/fsm)

Looking at

it's only clear that https://github.com/viewflow/viewflow has more recent activity (last tag in django-fsm 08.2022 vs viewflow 09.2023) and is getting more attention. But it's not certainly visible, whether either library is actively maintained at the moment (even viewflow has simple PRs open from July).

As I've said, I'm in principle willing to become a Viewflow pro customer, but then it has to be clear what the situation is. Can you please comment something on this, as you're the main contributor to django-fsm and the only contributor to viewflow?

Thank you very much.
Best,
Dennis

@Natim
Copy link

Natim commented Nov 20, 2023

What do you think about moving its maintenance to Jazzband so that we can keep maintaining it?

@RemiDesgrange
Copy link

@kmmbvnr the workflow and code logic in viewflow is quite different from django-fsm. Same as @ds-clearago , can you elaborate on your plan for django-fsm.

Thx.

@ds-clearago
Copy link

ds-clearago commented Nov 27, 2023

@Natim The Jazzband issue is being discussed already in #285 and #298
Furthermore, looking at stories like this django-guardian/django-guardian#759, it doesn't seem to be as simple as "if no maintainer's here, then there will be plenty there" especially since the transition also requires effort + at least one project lead willing to be named as such on Jazzband's side.

So I think it comes down to what @kmmbvnr is planning with django-fsm and viewflow.

Looking at https://github.com/kmmbvnr/django-material being archived on Apr 12, 2023 in favor of viewflow but also no answer in viewflow/viewflow#400 "Is there a guide for seamless transition from django-material to django-viewflow?" since Oct 12th my best guess is that he's busy at the moment with other things in life rather than these packages...

@Natim
Copy link

Natim commented Nov 27, 2023

at least one project lead willing to be named as such on Jazzband's side.

We are ok to do the job with @pfouque

Ultimately we will start a django-fsm-2

@ds-clearago
Copy link

@kmmbvnr Is there any news from your side on this? Perhaps considering the developments visible in viewflow/viewflow#407 (comment) and pfouque/django-fsm-2#14 ?

@ds-clearago
Copy link

While there is no reply here, there has been a relevant comment on this elsewhere:
In https://github.com/viewflow/viewflow/wiki/Django%E2%80%90Material-and-Viewflow-1.x-migration-Guide#conceptual-changes it says

Django-fsm and django-material have been merged into django-viewflow. Now, you only need to install django-viewflow (or django-viewflow-pro).

@RemiDesgrange
Copy link

Thanks @ds-clearago

django-viewflow v2 is still in beta and published as a pre-release on Pypi. Lastest release is from september 2023.

Even if I like the decoupling between the "flow" (state machine) and actual models in viewflow vs having heavy models in django-fsm, both options seem valid to me. Can't see why we couldn't have django-fsm in parrallel of django-viewflow. I understand perfectly if @kmmbvnr doesn't want to maintain this library and viewflow.
Amazing job has been done. Maybe we could continue it? Here or elsewhere.

@kmmbvnr
Copy link
Collaborator

kmmbvnr commented Feb 9, 2024

Guys, Viewflow would be released soon as a stable.

viewflow.fsm is the django-fsm (3.0)

django-fsm 2.x was released as 2014 has several design flaws and quite obsolete

@kmmbvnr kmmbvnr closed this as completed Feb 9, 2024
@viewflow viewflow locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants